From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: add read only to whitelist
Date: Tue, 28 May 2013 10:00:19 +0200 [thread overview]
Message-ID: <20130528080019.GB2854@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1369723466-3288-1-git-send-email-famz@redhat.com>
Am 28.05.2013 um 08:44 hat Fam Zheng geschrieben:
> We may want to include a driver in the whitelist for read only tasks
> such as diagnosing or exporting guest data (with libguestfs as a good
> example). This patch introduces the magic prefix ^ to include a driver
> to the whitelist, but only enables qemu to open specific image
> format readonly, and returns -ENOTSUP for RW opening.
>
> Example: To include vmdk readonly, and others read+write:
> ./configure --block-drv-whitelist=qcow2,raw,file,qed,^vmdk
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
^ looks a bit like "not", so this is potentially confusing syntax. Why
not simply add a second option?
./configure --block-drv-whitelist=qcow2,raw,file,qed \
--block-drv-ro-whitelist=vmdk
Kevin
next prev parent reply other threads:[~2013-05-28 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 6:44 [Qemu-devel] [PATCH] block: add read only to whitelist Fam Zheng
2013-05-28 8:00 ` Kevin Wolf [this message]
2013-05-28 8:02 ` Stefan Hajnoczi
2013-05-28 8:10 ` Paolo Bonzini
2013-05-28 8:34 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528080019.GB2854@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).