From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhUrh-0002ni-GC for qemu-devel@nongnu.org; Tue, 28 May 2013 21:08:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhUrQ-0000fw-Jh for qemu-devel@nongnu.org; Tue, 28 May 2013 21:07:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhUrQ-0000fg-BG for qemu-devel@nongnu.org; Tue, 28 May 2013 21:07:28 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4T17QS4019584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 May 2013 21:07:26 -0400 Date: Wed, 29 May 2013 09:07:25 +0800 From: Fam Zheng Message-ID: <20130529010725.GA3181@localhost.nay.redhat.com> References: <1369373827-9152-1-git-send-email-famz@redhat.com> <20130528103520.GB5105@redhat.com> <20130528110155.GC5105@redhat.com> <20130528111401.GA11749@localhost.nay.redhat.com> <20130528112539.GH4515@redhat.com> <20130528113215.GD5105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130528113215.GD5105@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On Tue, 05/28 12:32, Richard W.M. Jones wrote: > > This fixes the obvious bug. Thanks for figuring out this. Mainline had this 5s timeout so I kept it, but you don't experience this bug, right? Since master doesn't setup a timer to get curl notified about the timing, the option is just not effective. > I wonder if it should be even larger? One use for curl is to install > guests using ISOs from websites without having to download the ISO, > and I imagine that even a 30 second timeout could be conservative for > that task. > Long latency network is common in practice, as well as low bandwidth, the meaning of the timeout is to complete the request, in extreme cases if it is a 1Kbps link, downloading 256k takes minutes. Anyway, I think making it larger won't hurt. -- Fam