From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhYxC-0001vi-A5 for qemu-devel@nongnu.org; Wed, 29 May 2013 01:29:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhYx9-0000pN-Rs for qemu-devel@nongnu.org; Wed, 29 May 2013 01:29:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhYx9-0000pG-KF for qemu-devel@nongnu.org; Wed, 29 May 2013 01:29:39 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4T5TcvZ003815 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 01:29:38 -0400 Date: Wed, 29 May 2013 13:29:34 +0800 From: Fam Zheng Message-ID: <20130529052934.GA1350@localhost.nay.redhat.com> References: <1369753897-15140-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369753897-15140-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org On Tue, 05/28 17:11, Stefan Hajnoczi wrote: > Tests 030 and 041 are written in Python and use the iotests.py module. Push > common code down into iotests.py. My 'drive-backup' series takes advantage > will take advantage of this - kwolf pointed out that earlier revisions were Do you mean s/takes advantage will take advantage/will take advantage/? > duplicating too much code. > > I decided to split this into a separate patch series and send it before the > next 'drive-backup' revision. > > Stefan Hajnoczi (4): > qemu-iotests: make assert_no_active_block_jobs() common > qemu-iotests: make cancel_and_wait() common > qemu-iotests: make compare_images() common > qemu-iotests: make create_image() common > > tests/qemu-iotests/030 | 99 ++++++++--------------- > tests/qemu-iotests/041 | 181 +++++++++++++++--------------------------- > tests/qemu-iotests/iotests.py | 38 +++++++++ > 3 files changed, 135 insertions(+), 183 deletions(-) > > -- > 1.8.1.4 > > -- Fam