From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhdFC-00015q-6M for qemu-devel@nongnu.org; Wed, 29 May 2013 06:04:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhdF6-0005UO-UH for qemu-devel@nongnu.org; Wed, 29 May 2013 06:04:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhdF6-0005U2-NA for qemu-devel@nongnu.org; Wed, 29 May 2013 06:04:28 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TA4RtQ000367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 06:04:27 -0400 Date: Wed, 29 May 2013 12:04:26 +0200 From: Kevin Wolf Message-ID: <20130529100425.GE3521@dhcp-200-207.str.redhat.com> References: <1369753897-15140-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369753897-15140-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Am 28.05.2013 um 17:11 hat Stefan Hajnoczi geschrieben: > Tests 030 and 041 are written in Python and use the iotests.py module. Push > common code down into iotests.py. My 'drive-backup' series takes advantage > will take advantage of this - kwolf pointed out that earlier revisions were > duplicating too much code. > > I decided to split this into a separate patch series and send it before the > next 'drive-backup' revision. > > Stefan Hajnoczi (4): > qemu-iotests: make assert_no_active_block_jobs() common > qemu-iotests: make cancel_and_wait() common > qemu-iotests: make compare_images() common > qemu-iotests: make create_image() common > > tests/qemu-iotests/030 | 99 ++++++++--------------- > tests/qemu-iotests/041 | 181 +++++++++++++++--------------------------- > tests/qemu-iotests/iotests.py | 38 +++++++++ > 3 files changed, 135 insertions(+), 183 deletions(-) Looks correct, but I had a question/comment about patch 2. Kevin