From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33100)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UhdQy-0004MI-6X
	for qemu-devel@nongnu.org; Wed, 29 May 2013 06:16:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UhdQw-0001GP-Jx
	for qemu-devel@nongnu.org; Wed, 29 May 2013 06:16:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36337)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UhdQw-0001GK-C2
	for qemu-devel@nongnu.org; Wed, 29 May 2013 06:16:42 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TAGfdj027753
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 May 2013 06:16:41 -0400
Date: Wed, 29 May 2013 12:16:39 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130529101639.GF3521@dhcp-200-207.str.redhat.com>
References: <1369816901-7438-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1369816901-7438-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block: add block driver read only
	whitelist
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 29.05.2013 um 10:41 hat Fam Zheng geschrieben:
> We may want to include a driver in the whitelist for read only tasks
> such as diagnosing or exporting guest data (with libguestfs as a good
> example). This patch introduces a readonly whitelist option, and for
> backward compatibility, the old configure option --block-drv-whitelist
> is now an alias to rw whitelist.
> 
> Drivers in readonly list is only permitted to open file readonly, and
> returns -ENOTSUP for RW opening.
> 
> E.g. To include vmdk readonly, and others read+write:
>     ./configure --target-list=x86_64-softmmu \
>                 --block-drv-rw-whitelist=qcow2,raw,file,qed \
>                 --block-drv-ro-whitelist=vmdk
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>

Sorry, I'll have to drop the patch again:

  CC    hw/block/xen_disk.o
hw/block/xen_disk.c: In function 'blk_connect':
hw/block/xen_disk.c:799:25: error: too few arguments to function 'bdrv_find_whitelisted_format'
In file included from /home/kwolf/source/qemu/include/sysemu/blockdev.h:13:0,
                 from hw/block/xen_disk.c:41:
/home/kwolf/source/qemu/include/block/block.h:127:14: note: declared here

Should be trivial to fix, though.

Kevin