From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] block: add block driver read only whitelist
Date: Wed, 29 May 2013 20:04:48 +0800 [thread overview]
Message-ID: <20130529120448.GA2100@localhost.nay.redhat.com> (raw)
In-Reply-To: <20130529115606.GG3521@dhcp-200-207.str.redhat.com>
On Wed, 05/29 13:56, Kevin Wolf wrote:
> Am 29.05.2013 um 13:35 hat Fam Zheng geschrieben:
> > We may want to include a driver in the whitelist for read only tasks
> > such as diagnosing or exporting guest data (with libguestfs as a good
> > example). This patch introduces a readonly whitelist option, and for
> > backward compatibility, the old configure option --block-drv-whitelist
> > is now an alias to rw whitelist.
> >
> > Drivers in readonly list is only permitted to open file readonly, and
> > returns -ENOTSUP for RW opening.
> >
> > E.g. To include vmdk readonly, and others read+write:
> > ./configure --target-list=x86_64-softmmu \
> > --block-drv-rw-whitelist=qcow2,raw,file,qed \
> > --block-drv-ro-whitelist=vmdk
> >
> > v3:
> > Fix hw/block/xen_disk.c.
> >
> > v2:
> > Use a separate configure option, no more magic prefix.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > block.c | 43 +++++++++++++++++++++++++++----------------
> > blockdev.c | 4 ++--
> > configure | 20 +++++++++++++++-----
> > hw/block/xen_disk.c | 8 ++++++--
> > include/block/block.h | 3 ++-
> > scripts/create_config | 11 +++++++++--
> > 6 files changed, 61 insertions(+), 28 deletions(-)
>
> Thanks, applied to the block branch.
>
> For future patches, please make sure to include the version history of
> the patch below the "---" line so that git am automatically drops it.
OK, thanks for teaching me this.
--
Fam
prev parent reply other threads:[~2013-05-29 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 11:35 [Qemu-devel] [PATCH v3] block: add block driver read only whitelist Fam Zheng
2013-05-29 11:56 ` Kevin Wolf
2013-05-29 12:04 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529120448.GA2100@localhost.nay.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).