From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhfEZ-0002ww-K5 for qemu-devel@nongnu.org; Wed, 29 May 2013 08:12:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhfET-0005Na-BV for qemu-devel@nongnu.org; Wed, 29 May 2013 08:12:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhf7Z-0003La-Ru for qemu-devel@nongnu.org; Wed, 29 May 2013 08:04:50 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TC4nQU020531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 08:04:49 -0400 Date: Wed, 29 May 2013 20:04:48 +0800 From: Fam Zheng Message-ID: <20130529120448.GA2100@localhost.nay.redhat.com> References: <1369827340-32063-1-git-send-email-famz@redhat.com> <20130529115606.GG3521@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130529115606.GG3521@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] block: add block driver read only whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Wed, 05/29 13:56, Kevin Wolf wrote: > Am 29.05.2013 um 13:35 hat Fam Zheng geschrieben: > > We may want to include a driver in the whitelist for read only tasks > > such as diagnosing or exporting guest data (with libguestfs as a good > > example). This patch introduces a readonly whitelist option, and for > > backward compatibility, the old configure option --block-drv-whitelist > > is now an alias to rw whitelist. > > > > Drivers in readonly list is only permitted to open file readonly, and > > returns -ENOTSUP for RW opening. > > > > E.g. To include vmdk readonly, and others read+write: > > ./configure --target-list=x86_64-softmmu \ > > --block-drv-rw-whitelist=qcow2,raw,file,qed \ > > --block-drv-ro-whitelist=vmdk > > > > v3: > > Fix hw/block/xen_disk.c. > > > > v2: > > Use a separate configure option, no more magic prefix. > > > > Signed-off-by: Fam Zheng > > --- > > block.c | 43 +++++++++++++++++++++++++++---------------- > > blockdev.c | 4 ++-- > > configure | 20 +++++++++++++++----- > > hw/block/xen_disk.c | 8 ++++++-- > > include/block/block.h | 3 ++- > > scripts/create_config | 11 +++++++++-- > > 6 files changed, 61 insertions(+), 28 deletions(-) > > Thanks, applied to the block branch. > > For future patches, please make sure to include the version history of > the patch below the "---" line so that git am automatically drops it. OK, thanks for teaching me this. -- Fam