From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38824)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uhkf5-0004kl-MA
	for qemu-devel@nongnu.org; Wed, 29 May 2013 13:59:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Uhkf0-0005bh-Nu
	for qemu-devel@nongnu.org; Wed, 29 May 2013 13:59:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34002)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UhkWe-0002NM-2m
	for qemu-devel@nongnu.org; Wed, 29 May 2013 13:51:04 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4THp3cd011939
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 May 2013 13:51:03 -0400
Date: Wed, 29 May 2013 13:51:01 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130529135101.00122598@redhat.com>
In-Reply-To: <20130529081341.GB3521@dhcp-200-207.str.redhat.com>
References: <1369754856-30036-1-git-send-email-kwolf@redhat.com>
	<1369754856-30036-17-git-send-email-kwolf@redhat.com>
	<51A4D63B.3040103@redhat.com>
	<20130529081341.GB3521@dhcp-200-207.str.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in
 the monitor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, 29 May 2013 10:13:42 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 28.05.2013 um 18:07 hat Eric Blake geschrieben:
> > On 05/28/2013 09:27 AM, Kevin Wolf wrote:
> > > The QMP version is flagged with a __org.qemu.debug- prefix in order to
> > > reinforce the statement that qemu-io is for testing and debugging only,
> > > with no API guarantees.
> > 
> > Correct use of naming conventions.
> > 
> > Hmm, I wonder if the recent addition of an 'abort' action to
> > 'transaction' should be renamed __org.qemu.debug-abort, to make it
> > obvious that it is another case of a QMP command useful mainly for
> > testing, and not real-life use.
> 
> Makes sense to me.
> 
> But first I'd like to get Luiz's ack for this, because I think I'm the
> first one to use an __org.qemu prefix, and I'm the first one trying to
> introduce a QMP command without API stability.

I think that should be fine. However, it's not a perfect match for QMP
as you don't expect mngt to use it anytime soon and that the command's
syntax is not QMP friendly:

> { "execute": "__org.qemu.debug-qemu-io-command", "arguments":
>     { "device": "ide0-hd0", "command": "write -P 0x12 4M 512k" } }

What about adding a HMP-only command (the good old way) and use it
through human-monitor-command?

IMO, this matches better your current use-case and the API instability
of the command.