From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42085)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Uhh3b-0000oA-GE
	for qemu-devel@nongnu.org; Wed, 29 May 2013 10:08:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Uhh3U-0004di-Ut
	for qemu-devel@nongnu.org; Wed, 29 May 2013 10:08:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23630)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Uhh3U-0004dY-LE
	for qemu-devel@nongnu.org; Wed, 29 May 2013 10:08:44 -0400
Date: Wed, 29 May 2013 17:09:00 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130529140900.GA10347@redhat.com>
References: <51A25A2D.8030700@redhat.com> <20130526200251.GA4305@redhat.com>
	<51A26E95.5000207@redhat.com> <878v314gb2.fsf@codemonkey.ws>
	<20130526214213.GB4828@redhat.com> <87txlp1bsy.fsf@codemonkey.ws>
	<20130527150217.GA16852@redhat.com> <87bo7wflhk.fsf@codemonkey.ws>
	<87ip22od5f.fsf@rustcorp.com.au> <87hahmq6li.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87hahmq6li.fsf@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in
 portable code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, virtualization <virtualization@lists.linux-foundation.org>, qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>

On Wed, May 29, 2013 at 08:05:29AM -0500, Anthony Liguori wrote:
> Rusty Russell <rusty@rustcorp.com.au> writes:
> 
> > Anthony Liguori <anthony@codemonkey.ws> writes:
> >> The headers say they are BSD licensed... but they include a GPLv2+
> >> header.  Doesn't make a lot of sense, does it?
> >
> > It makes perfect sense: you're overthinking it.  It just means that
> > copying the BSD headers outside Linux is encouraged.
> 
> Copying by hand and modifying.  This patch series attempts to do it
> automatically within QEMU.
> 
> > And it's clearly nonsensical to claim the GPL on kernel headers means
> > that userspace needs to be GPL.  So please ignore this licensing
> > red-herring.
> 
> You're missing context, I suspect.  This series is trying to
> automatically copy the headers from Linux.  We currently have a manually
> copied version.
> 
> The headers are not currently well suited for automatic copying because
> (1) they use kernel types (2) they pull in dependencies from throughout
> the kernel.
> 
> This discussion comes down to whether we want to make it easier to
> automatically copy the headers or do we maintain the status quo and
> require manual munging to pull in the headers.
> 
> Regards,
> 
> Anthony Liguori

Okay, what if I

1. add a stub if_ether.h with a couple of macros we want
2. replace the types during copying

Would this address all concerns?

> >
> > And we'll bikeshed the headers in the standard when we have to :)  They
> > certainly don't need to be cut&paste into the kernel sources.
> >
> > Cheers,
> > Rusty.