From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UhhTa-0005nZ-6l
	for qemu-devel@nongnu.org; Wed, 29 May 2013 10:35:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UhhTV-0005jC-JW
	for qemu-devel@nongnu.org; Wed, 29 May 2013 10:35:42 -0400
Date: Wed, 29 May 2013 16:35:27 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130529163527.54680385@nial.usersys.redhat.com>
In-Reply-To: <51A5F4BF.90504@redhat.com>
References: <alpine.DEB.2.02.1305291205540.4799@kaball.uk.xensource.com>
	<1369827271-20921-3-git-send-email-stefano.stabellini@eu.citrix.com>
	<51A5F06A.4040109@suse.de> <51A5F4BF.90504@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/3] xen_machine_pv: do not create a
 dummy CPU in machine->init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org, anthony.perard@citrix.com, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Wed, 29 May 2013 14:29:51 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 29/05/2013 14:11, Andreas F=E4rber ha scritto:
> >> xen_machine_pv uses cpu_x86_init, therefore it has been broken.
> >>
> >> This patch fixes the problem by removing the dummy CPU creation
> >> altogether from xen_init_pv, relying on the fact that QEMU can now cope
> >> with a machine without an emulated CPU.
> >>
> >> This fix should be backported to QEMU 1.5.
> >>
> >> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >> CC: imammedo@redhat.com
> >> CC: qemu-stable@nongnu.org
> >=20
> > Change looks okay,
> >=20
> > Reviewed-by: Andreas F=E4rber <afaerber@suse.de>
> >=20
> > But for the future please avoid "this patch" in the commit message
> > (because later on it's a "commit", not a patch) and also please put
> > additional notices such as for backporting below the --- line.
>=20
> I read it as a warning to backporters that the patch, even though it may
> apply, was not tested and may even be wrong in 1.4.
it only needs to be backported to 1.5, 1.4 is not affected.

>=20
> Paolo
>=20