From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UhxDb-00078u-F4
	for qemu-devel@nongnu.org; Thu, 30 May 2013 03:24:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UhxDV-0007lr-IE
	for qemu-devel@nongnu.org; Thu, 30 May 2013 03:24:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15030)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UhxDV-0007lm-78
	for qemu-devel@nongnu.org; Thu, 30 May 2013 03:24:09 -0400
Date: Thu, 30 May 2013 09:24:05 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130530072405.GA14690@stefanha-thinkpad.redhat.com>
References: <1369827246-2802-1-git-send-email-kwolf@redhat.com>
	<1369827246-2802-4-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1369827246-2802-4-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] ide-test: Add FLUSH CACHE test case
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, afaerber@suse.de

On Wed, May 29, 2013 at 01:34:06PM +0200, Kevin Wolf wrote:
> +    /* Check registers */
> +    data = inb(IDE_BASE + reg_device);
> +    g_assert_cmpint(data & 0x10, ==, 0);

assert_bit_clear() with a constant instead of the 0x10 magic number?