From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 0/3] ide: Set BSY bit during FLUSH
Date: Thu, 30 May 2013 09:25:44 +0200 [thread overview]
Message-ID: <20130530072544.GB14690@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1369827246-2802-1-git-send-email-kwolf@redhat.com>
On Wed, May 29, 2013 at 01:34:03PM +0200, Kevin Wolf wrote:
> The test case depends on the qemu-io series I sent yesterday.
> ("[PATCH 00/16] Make qemu-io commands available in the monitor")
>
> Andreas Färber (1):
> ide: Set BSY bit during FLUSH
>
> Kevin Wolf (2):
> blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events
> ide-test: Add FLUSH CACHE test case
>
> block.c | 8 ++++----
> block/blkdebug.c | 3 +++
> hw/ide/core.c | 3 +++
> include/block/block.h | 3 +++
> tests/ide-test.c | 40 ++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 53 insertions(+), 4 deletions(-)
Looks good. I really like the test case.
Posted a minor comment on the test case.
Stefan
prev parent reply other threads:[~2013-05-30 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 11:34 [Qemu-devel] [PATCH 0/3] ide: Set BSY bit during FLUSH Kevin Wolf
2013-05-29 11:34 ` [Qemu-devel] [PATCH 1/3] blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events Kevin Wolf
2013-05-29 11:34 ` [Qemu-devel] [PATCH 2/3] ide: Set BSY bit during FLUSH Kevin Wolf
2013-05-29 11:50 ` Andreas Färber
2013-05-29 12:46 ` Kevin Wolf
2013-05-29 11:34 ` [Qemu-devel] [PATCH 3/3] ide-test: Add FLUSH CACHE test case Kevin Wolf
2013-05-30 7:24 ` Stefan Hajnoczi
2013-05-30 7:25 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530072544.GB14690@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).