From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52684)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1UhxGb-0001wy-I6
	for qemu-devel@nongnu.org; Thu, 30 May 2013 03:27:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1UhxGW-000072-N9
	for qemu-devel@nongnu.org; Thu, 30 May 2013 03:27:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1UhxGW-00006w-Ef
	for qemu-devel@nongnu.org; Thu, 30 May 2013 03:27:16 -0400
Date: Thu, 30 May 2013 15:27:12 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20130530072712.GA6320@t430s.nay.redhat.com>
References: <1369882068-5483-1-git-send-email-akong@redhat.com>
	<20130530060905.GB9952@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130530060905.GB9952@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pci: change typename of q35 to pci-q35
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: pbonzini@redhat.com, kevin@koconnor.net, seabios@seabios.org, qemu-devel@nongnu.org, aliguori@us.ibm.com

On Thu, May 30, 2013 at 09:09:05AM +0300, Michael S. Tsirkin wrote:
> On Thu, May 30, 2013 at 10:47:48AM +0800, Amos Kong wrote:
> > In QEMU, we set the firmware name of pc-i440fx is 'pci', and set the
> > firmware name of q35 is 'q35-pcihost'.
> > 
> > The seabios pattern matching code isn't sophisticated, and we want to
> > match those two devices with exact pattern.
> > 
> > This patch changes the typename of q35 to 'pci-q35', all pci devices
> > use same prefix 'pci' in fireware name. And I will change pattern in
> > seabios to "/pci*@i0cf8".
> > 
> > Signed-off-by: Amos Kong <akong@redhat.com>
> 
> Let's just not leak name to the guest - there's no reason to.
> 
> Won't the following address the issue without bios changes?
> Maybe we should find some way to set fw_name in hw/pci/pci_host.c,
> worth looking into.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> ---
> 
> 
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 8467f86..24df6b5 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -76,6 +76,7 @@ static void q35_host_class_init(ObjectClass *klass, void *data)
>  
>      k->init = q35_host_init;
>      dc->props = mch_props;
> +    dc->fw_name = "pci";

It's a light change, works with current seabios.

>  }
>  
>  static void q35_host_initfn(Object *obj)

-- 
			Amos.