* [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci
@ 2013-05-30 7:25 Amos Kong
2013-05-30 7:44 ` Michael S. Tsirkin
2013-05-30 8:38 ` Michael S. Tsirkin
0 siblings, 2 replies; 3+ messages in thread
From: Amos Kong @ 2013-05-30 7:25 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, aliguori, seabios, kevin, mst
In QEMU, we set the firmware name of pc-i440fx to 'pci', and the
typename 'q35-pcihost' is set to the firmware name of q35 by default.
The seabios matches pci devices by "/pci/@i0cf8", so q35 device
could not be identified, seabios fails to adjust the boot priority
of q35 devices.
This patch sets firmware name of q35 to 'pci'.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
v2: just set the fw_name, no need to change seabios
---
hw/pci-host/q35.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 8467f86..24df6b5 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -76,6 +76,7 @@ static void q35_host_class_init(ObjectClass *klass, void *data)
k->init = q35_host_init;
dc->props = mch_props;
+ dc->fw_name = "pci";
}
static void q35_host_initfn(Object *obj)
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci
2013-05-30 7:25 [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci Amos Kong
@ 2013-05-30 7:44 ` Michael S. Tsirkin
2013-05-30 8:38 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2013-05-30 7:44 UTC (permalink / raw)
To: Amos Kong; +Cc: pbonzini, aliguori, seabios, qemu-devel, kevin
On Thu, May 30, 2013 at 03:25:17PM +0800, Amos Kong wrote:
> In QEMU, we set the firmware name of pc-i440fx to 'pci', and the
> typename 'q35-pcihost' is set to the firmware name of q35 by default.
>
> The seabios matches pci devices by "/pci/@i0cf8", so q35 device
> could not be identified, seabios fails to adjust the boot priority
> of q35 devices.
>
> This patch sets firmware name of q35 to 'pci'.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Amos Kong <akong@redhat.com>
Does this imply
Tested-by: Amos Kong <akong@redhat.com>
?
> ---
> v2: just set the fw_name, no need to change seabios
> ---
> hw/pci-host/q35.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 8467f86..24df6b5 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -76,6 +76,7 @@ static void q35_host_class_init(ObjectClass *klass, void *data)
>
> k->init = q35_host_init;
> dc->props = mch_props;
> + dc->fw_name = "pci";
> }
>
> static void q35_host_initfn(Object *obj)
> --
> 1.8.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci
2013-05-30 7:25 [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci Amos Kong
2013-05-30 7:44 ` Michael S. Tsirkin
@ 2013-05-30 8:38 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2013-05-30 8:38 UTC (permalink / raw)
To: Amos Kong; +Cc: pbonzini, aliguori, seabios, qemu-devel, kevin
On Thu, May 30, 2013 at 03:25:17PM +0800, Amos Kong wrote:
> In QEMU, we set the firmware name of pc-i440fx to 'pci', and the
> typename 'q35-pcihost' is set to the firmware name of q35 by default.
>
> The seabios matches pci devices by "/pci/@i0cf8", so q35 device
> could not be identified, seabios fails to adjust the boot priority
> of q35 devices.
>
> This patch sets firmware name of q35 to 'pci'.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Amos Kong <akong@redhat.com>
I've applied this already.
> ---
> v2: just set the fw_name, no need to change seabios
> ---
> hw/pci-host/q35.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 8467f86..24df6b5 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -76,6 +76,7 @@ static void q35_host_class_init(ObjectClass *klass, void *data)
>
> k->init = q35_host_init;
> dc->props = mch_props;
> + dc->fw_name = "pci";
> }
>
> static void q35_host_initfn(Object *obj)
> --
> 1.8.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-30 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-30 7:25 [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci Amos Kong
2013-05-30 7:44 ` Michael S. Tsirkin
2013-05-30 8:38 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).