From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38657)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UhyNU-00077y-QI
	for qemu-devel@nongnu.org; Thu, 30 May 2013 04:38:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UhyNO-0005kR-JL
	for qemu-devel@nongnu.org; Thu, 30 May 2013 04:38:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34180)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UhyNO-0005kN-Ax
	for qemu-devel@nongnu.org; Thu, 30 May 2013 04:38:26 -0400
Date: Thu, 30 May 2013 11:38:50 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130530083850.GC27703@redhat.com>
References: <1369898717-7592-1-git-send-email-akong@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1369898717-7592-1-git-send-email-akong@redhat.com>
Subject: Re: [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to
	pci
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, seabios@seabios.org, qemu-devel@nongnu.org, kevin@koconnor.net

On Thu, May 30, 2013 at 03:25:17PM +0800, Amos Kong wrote:
> In QEMU, we set the firmware name of pc-i440fx to 'pci', and the
> typename 'q35-pcihost' is set to the firmware name of q35 by default.
> 
> The seabios matches pci devices by "/pci/@i0cf8", so q35 device
> could not be identified, seabios fails to adjust the boot priority
> of q35 devices.
> 
> This patch sets firmware name of q35 to 'pci'.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Amos Kong <akong@redhat.com>

I've applied this already.

> ---
> v2: just set the fw_name, no need to change seabios
> ---
>  hw/pci-host/q35.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 8467f86..24df6b5 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -76,6 +76,7 @@ static void q35_host_class_init(ObjectClass *klass, void *data)
>  
>      k->init = q35_host_init;
>      dc->props = mch_props;
> +    dc->fw_name = "pci";
>  }
>  
>  static void q35_host_initfn(Object *obj)
> -- 
> 1.8.1.4