From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35618)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Ui6Gv-0008UK-IX
	for qemu-devel@nongnu.org; Thu, 30 May 2013 13:04:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Ui6Gq-0006wM-Tk
	for qemu-devel@nongnu.org; Thu, 30 May 2013 13:04:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52219)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Ui6Gq-0006w8-Mm
	for qemu-devel@nongnu.org; Thu, 30 May 2013 13:04:12 -0400
Date: Thu, 30 May 2013 13:03:33 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130530130333.30ae2a21@redhat.com>
In-Reply-To: <CAFe8ug_UzYV3_vvkbDVog6rH9a_g+w8R2OY21Jh0TWDW9Q5rVQ@mail.gmail.com>
References: <20130530114604.4b12cb22@redhat.com> <51A77838.4060707@redhat.com>
	<20130530120832.5abe1c65@redhat.com>
	<CAFe8ug_UzYV3_vvkbDVog6rH9a_g+w8R2OY21Jh0TWDW9Q5rVQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering
 overlapping slot: Invalid argument
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jordan Justen <jljusten@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, "Justen,
	Jordan L" <jordan.l.justen@intel.com>

On Thu, 30 May 2013 09:50:10 -0700
Jordan Justen <jljusten@gmail.com> wrote:

> On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > On Thu, 30 May 2013 18:03:04 +0200
> > Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> >> Il 30/05/2013 17:46, Luiz Capitulino ha scritto:
> >> > The culprit is commit:
> >> >
> >> > commit 235e8982ad393e5611cb892df54881c872eea9e1
> >> > Author: Jordan Justen <jordan.l.justen@intel.com>
> >> > Date:   Wed May 29 01:27:26 2013 -0700
> >> >
> >> >     kvm: support using KVM_MEM_READONLY flag for regions
> >> >
> >> > I'm running 3.9.2-200.fc18, btw. And, error checking is missing on the
> >> > first call to kvm_vm_ioctl().
> 
> As noted in the code, the first call is for KVM commit 75d61fbc.
> 
> I'm not sure we want to fail if an error occurs when making that call.
> (I'm pretty sure we don't want to in fact.)
> 
> Xiao, any thoughts?
> 
> >> Reproducer?
> >
> > I just try to start a VM (HEAD 87d23f7):
> >
> > ~/work/virt/ sudo ./qemu-qmp -drive file=disks/test.img,if=virtio,cache=none,aio=native -enable-kvm -m 1G -monitor stdio -cpu host -snapshot
> > QEMU 1.5.50 monitor - type 'help' for more information
> > (qemu) kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument
> > ~/work/virt/
> 
> Sorry. I am working with Linux 3.8.0, and I don't see this. I'll try
> to update my kernel.
> 
> Does the firmware behave as a ROM for you?

I think so:

(qemu) info roms
fw=genroms/kvmvapic.bin size=0x002400 name="kvmvapic.bin"
addr=00000000fffe0000 size=0x020000 mem=rom name="bios.bin"
(qemu) 

Is this what you're asking?