From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiEVP-0002zC-NV for qemu-devel@nongnu.org; Thu, 30 May 2013 21:51:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiEVO-0008SN-Ro for qemu-devel@nongnu.org; Thu, 30 May 2013 21:51:47 -0400 Received: from [222.73.24.84] (port=25373 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiEVO-0008SF-HM for qemu-devel@nongnu.org; Thu, 30 May 2013 21:51:46 -0400 Date: Fri, 31 May 2013 09:51:05 +0800 From: Hu Tao Message-ID: <20130531015105.GF9509@localhost.localdomain> References: <1369920427-18274-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <1369920427-18274-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Subject: Re: [Qemu-devel] [PATCH 0/3] fw_cfg: misc fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Thu, May 30, 2013 at 04:27:56PM +0300, Michael S. Tsirkin wrote: > Here are some misc fixes to the fw cfg object > handling. > I've queued them on my pci branch temporarily > as it's useful to cleanup some pci things. > I'm using this with Laszlo's cleanup patch > that got rid of void * in pc.c too - > that's queued there as well. > > Please review and comment. > > Michael S. Tsirkin (3): > pvpanic: use FWCfgState explicitly > fw_cfg: add API to find FW cfg object > fw_cfg: fw_cfg is a singleton > > hw/misc/pvpanic.c | 4 ++-- > hw/nvram/fw_cfg.c | 18 +++++++++++++----- > include/hw/nvram/fw_cfg.h | 2 ++ > 3 files changed, 17 insertions(+), 7 deletions(-) > > -- > MST > Series looks good to me, except a reorder.