From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiGs8-0006b7-2N for qemu-devel@nongnu.org; Fri, 31 May 2013 00:23:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiGs2-0004h2-OP for qemu-devel@nongnu.org; Fri, 31 May 2013 00:23:24 -0400 Received: from ozlabs.org ([2402:b800:7003:1:1::1]:35330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiGZJ-0007UD-1O for qemu-devel@nongnu.org; Fri, 31 May 2013 00:03:57 -0400 Date: Fri, 31 May 2013 13:32:45 +1000 From: David Gibson Message-ID: <20130531033245.GB5408@boomeroo.fritz.box> References: <9b6a3a52e3f46cfbc1ded9ab56385ec045e46705.1369628289.git.peter.crosthwaite@xilinx.com> <20130529081853.GC5489@boomeroo.fritz.box> <20130529093157.GF5489@boomeroo.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GID0FwUMdk1T2AWN" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , edgar.iglesias@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com --GID0FwUMdk1T2AWN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 31, 2013 at 11:48:47AM +1000, Peter Crosthwaite wrote: > Hi David, >=20 > On Wed, May 29, 2013 at 7:31 PM, David Gibson > wrote: > > On Wed, May 29, 2013 at 10:14:19AM +0100, Peter Maydell wrote: > >> On 29 May 2013 09:18, David Gibson wrote: > >> > On Mon, May 27, 2013 at 02:20:57PM +1000, peter.crosthwaite@xilinx.c= om wrote: > >> >> From: Peter Crosthwaite > >> >> Currently QEMU provides a local clone of the file libfdt_env.h in > >> >> /include. This file is supposed to come with the libfdt package and= is > >> > > >> > So, this patch might be the right thing anyway, but the statement > >> > above is entirely false. libfdt_env.h is explicitly intended to be > >> > supplied by the build environment embedding libfdt. The version > >> > provided in the libfdt package is a example version which will do > >> > (although it might not be ideal) for userspace builds with a > >> > sufficiently normal C library. > >> > >> (You're upstream for libfdt, yes?) > > > > More or less, yes. > > > >> If you're expecting that build environments provide a libfdt_env.h > >> then shouldn't you be avoiding making breaking changes to libfdt > >> that require build environments to fix their libfdt_env.h? > >> This came up in the first place because we no longer build with > >> new libfdt... > > > > I missed that discussion, what exactly was the problem? >=20 > In file included from /usr/local/include/libfdt.h:55, > from > /home/peterc/Petalogix/Internal/plgx_src/qemu-arm-microblazeel/device_tre= e.c:28: > /usr/local/include/fdt.h:7: error: expected specifier-qualifier-list > before =E2=80=98fdt32_t=E2=80=99 > /usr/local/include/fdt.h:26: error: expected specifier-qualifier-list > before =E2=80=98fdt64_t=E2=80=99 > /usr/local/include/fdt.h:31: error: expected specifier-qualifier-list > before =E2=80=98fdt32_t=E2=80=99 > /usr/local/include/fdt.h:36: error: expected specifier-qualifier-list > before =E2=80=98fdt32_t=E2=80=99 >=20 > The type fdt32_t (and friends) is undefined. >=20 > Heres the patch DTC side that introduces these types. >=20 > commit feafcd972cb744750a65728440c99526e6199a6d > Author: Kim Phillips > Date: Wed Nov 28 17:33:01 2012 -0600 >=20 > dtc/libfdt: introduce fdt types for annotation by endian > checkers Ah, that one. Basically, we decided that the benefit gained was worth the pain of the required change to libfdt_env.h > > Then again, although we certainly > > want to keep changes which require updates to libfdt_env.h rare, I'm > > not going to rule out extensions to libfdt which add new (minor) > > external dependencies, and therefore changes to libfdt_env.h. > > > > That said, I did put my correction a bit too strongly. While > > libfdt_env.h is notionally always provided by the surrounding > > environment, if the packaged one works for your environment, it's > > probably a good idea to use it. >=20 > I think we should be able to consider QEMU as normal enough to use > prepacked DTC and just fix the commit message? I concur. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GID0FwUMdk1T2AWN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGoGd0ACgkQaILKxv3ab8a54QCfXolS05qiMc4P+zjHWE1q1Jvw IIMAnApLc7+DfLNYZ7YiLMm9ap4TqzmX =gp56 -----END PGP SIGNATURE----- --GID0FwUMdk1T2AWN--