From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UiOcl-0006Qd-Ot
	for qemu-devel@nongnu.org; Fri, 31 May 2013 08:40:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UiOck-0002B3-Cx
	for qemu-devel@nongnu.org; Fri, 31 May 2013 08:40:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UiOck-00027n-6U
	for qemu-devel@nongnu.org; Fri, 31 May 2013 08:40:02 -0400
Date: Fri, 31 May 2013 08:39:21 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130531083921.3c68faae@redhat.com>
In-Reply-To: <51A864C2.8090904@linux.vnet.ibm.com>
References: <20130530114604.4b12cb22@redhat.com> <51A77838.4060707@redhat.com>
	<20130530120832.5abe1c65@redhat.com>
	<CAFe8ug_UzYV3_vvkbDVog6rH9a_g+w8R2OY21Jh0TWDW9Q5rVQ@mail.gmail.com>
	<51A8485A.4000605@linux.vnet.ibm.com> <51A85DE8.2090600@redhat.com>
	<51A864C2.8090904@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH uq/master] fix double free the memslot in
 kvm_set_phys_mem
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Gleb Natapov <gleb@redhat.com>, KVM <kvm@vger.kernel.org>, "Justen,
	Jordan L" <jordan.l.justen@intel.com>, qemu-devel <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Jordan Justen <jljusten@gmail.com>

On Fri, 31 May 2013 16:52:18 +0800
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:

> Luiz Capitulino reported that guest refused to boot and qemu
> complained with:
> kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument
> 
> It is caused by commit 235e8982ad that did double free for the memslot
> so that the second one raises the -EINVAL error
> 
> Fix it by reset memory size only if it is needed
> 
> Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>

Tested-by: Luiz Capitulino <lcapitulino@redhat.com>

Thanks Xiao for the fix, and thanks everyone for debugging this issue!

> ---
>  kvm-all.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index 8e7bbf8..405480e 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -206,7 +206,8 @@ static int kvm_set_user_memory_region(KVMState *s, KVMSlot *slot)
>      if (s->migration_log) {
>          mem.flags |= KVM_MEM_LOG_DIRTY_PAGES;
>      }
> -    if (mem.flags & KVM_MEM_READONLY) {
> +
> +    if (slot->memory_size && mem.flags & KVM_MEM_READONLY) {
>          /* Set the slot size to 0 before setting the slot to the desired
>           * value. This is needed based on KVM commit 75d61fbc. */
>          mem.memory_size = 0;