From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57179)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UiQ7c-0003l4-OC
	for qemu-devel@nongnu.org; Fri, 31 May 2013 10:16:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UiQ7W-0004Oy-Ou
	for qemu-devel@nongnu.org; Fri, 31 May 2013 10:16:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51294)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UiQ7W-0004Ot-4r
	for qemu-devel@nongnu.org; Fri, 31 May 2013 10:15:54 -0400
Date: Fri, 31 May 2013 09:19:32 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130531091932.61d4cc03@redhat.com>
In-Reply-To: <51A89FCA.5080707@linux.vnet.ibm.com>
References: <1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<20130527154139.GH2373@dhcp-200-207.str.redhat.com>
	<51A6BC41.7090803@linux.vnet.ibm.com>
	<51A89FCA.5080707@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in
 block layer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com

On Fri, 31 May 2013 21:04:10 +0800
Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:

> =E4=BA=8E 2013-5-30 10:41, Wenchao Xia =E5=86=99=E9=81=93:
> > =E4=BA=8E 2013-5-27 23:41, Kevin Wolf =E5=86=99=E9=81=93:
> >> Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben:
> >>> These patches are the common part of my hmp/qmp block query series
> >>> and Pavel's
> >>> qmp snapshot command converion series. It mainly does following thing=
s:
> >>> 1 move snapshot related code to block/snapshot.c, qmp and info
> >>> dumping code to
> >>> block/qapi.c.
> >>> 2 better info dumping function to get rid of buffer, avoid string
> >>> truncation.
> >>
> >> Posted comments on patch 1 and 4.
> >>
> >> Patches 2 and 3 are:
> >> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> >>
> >    It seems nothing need change, Kevin, do you think it can be merged?
> >
>    This serial blocks mine and Pavel's work, anything need to be
> improved? Respin with
> -typedef int (*fprintf_function)(FILE *f, const char *fmt, ...)
> +typedef int (*fprintf_function)(void *out, const char *fmt, ...)
> ?

As far as my review is concerned, I'm OK with your current version.