* [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro
@ 2013-05-28 10:20 Michael S. Tsirkin
2013-05-31 18:48 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2013-05-28 10:20 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Paolo Bonzini, Anthony Liguori, KONRAD Frederic
The implementation is wrong for kvm, and it's unused anyway.
Drop it.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/virtio-pci.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 87b78bc..f4db224 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -89,12 +89,6 @@
/* Flags track per-device state like workarounds for quirks in older guests. */
#define VIRTIO_PCI_FLAG_BUS_MASTER_BUG (1 << 0)
-/* QEMU doesn't strictly need write barriers since everything runs in
- * lock-step. We'll leave the calls to wmb() in though to make it obvious for
- * KVM or if kqemu gets SMP support.
- */
-#define wmb() do { } while (0)
-
/* HACK for virtio to determine if it's running a big endian guest */
bool virtio_is_big_endian(void);
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro
@ 2013-05-30 9:28 Michael S. Tsirkin
2013-05-31 18:48 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2013-05-30 9:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori
The implementation is wrong for kvm, and it's unused anyway.
Drop it.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 20130528102023.GA30055@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
hw/virtio/virtio-pci.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 70d2c6b..444b71a 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -89,12 +89,6 @@
/* Flags track per-device state like workarounds for quirks in older guests. */
#define VIRTIO_PCI_FLAG_BUS_MASTER_BUG (1 << 0)
-/* QEMU doesn't strictly need write barriers since everything runs in
- * lock-step. We'll leave the calls to wmb() in though to make it obvious for
- * KVM or if kqemu gets SMP support.
- */
-#define wmb() do { } while (0)
-
/* HACK for virtio to determine if it's running a big endian guest */
bool virtio_is_big_endian(void);
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro
2013-05-30 9:28 Michael S. Tsirkin
@ 2013-05-31 18:48 ` Anthony Liguori
0 siblings, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2013-05-31 18:48 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro
2013-05-28 10:20 [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro Michael S. Tsirkin
@ 2013-05-31 18:48 ` Anthony Liguori
0 siblings, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2013-05-31 18:48 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Peter Maydell, Anthony Liguori, KONRAD Frederic, Paolo Bonzini
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-31 18:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-28 10:20 [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro Michael S. Tsirkin
2013-05-31 18:48 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-05-30 9:28 Michael S. Tsirkin
2013-05-31 18:48 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).