From: David Gibson <david@gibson.dropbear.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
qemu-devel@nongnu.org, edgar.iglesias@gmail.com
Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h
Date: Sat, 1 Jun 2013 15:22:42 +1000 [thread overview]
Message-ID: <20130601052242.GA12059@boomeroo.fritz.box> (raw)
In-Reply-To: <51A85E93.5010507@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]
On Fri, May 31, 2013 at 10:25:55AM +0200, Paolo Bonzini wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Il 31/05/2013 05:32, David Gibson ha scritto:
> >>> Then again, although we certainly want to keep changes which
> >>> require updates to libfdt_env.h rare, I'm not going to rule
> >>> out extensions to libfdt which add new (minor) external
> >>> dependencies, and therefore changes to libfdt_env.h.
> >>>
> >>> That said, I did put my correction a bit too strongly. While
> >>> libfdt_env.h is notionally always provided by the surrounding
> >>> environment, if the packaged one works for your environment,
> >>> it's probably a good idea to use it.
> >>
> >> I think we should be able to consider QEMU as normal enough to
> >> use prepacked DTC and just fix the commit message?
> >
> > I concur.
>
> Please don't. Fedora is not going to use the bundled dtc because of a
> policy against bundling, and Fedora's dtc package doesn't include
> libfdt_env.h.
Yeah, that makes Fedora's dtc (well, libfdt) package broken.
> If David says that the changes are rare enough, let's just fix the
> bundled libfdt_env.h.
That's definitely not right. If you're using an externally packagd
build of libfdt, you must use that external package's libfdt_env.h as
well (which in this case is the default version).
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-06-01 5:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 4:20 [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h peter.crosthwaite
2013-05-29 8:18 ` David Gibson
2013-05-29 9:14 ` Peter Maydell
2013-05-29 9:31 ` David Gibson
2013-05-31 1:48 ` Peter Crosthwaite
2013-05-31 3:32 ` David Gibson
2013-05-31 8:25 ` Paolo Bonzini
2013-05-31 9:44 ` Peter Maydell
2013-05-31 9:54 ` Paolo Bonzini
2013-05-31 12:37 ` Peter Crosthwaite
2013-06-01 5:38 ` David Gibson
2013-06-01 23:13 ` Peter Crosthwaite
2013-06-07 2:54 ` Peter Crosthwaite
2013-06-07 8:32 ` Peter Maydell
2013-06-01 5:22 ` David Gibson [this message]
2013-06-01 8:26 ` Peter Maydell
2013-06-01 23:09 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130601052242.GA12059@boomeroo.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).