From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uiecc-0005Fw-3r for qemu-devel@nongnu.org; Sat, 01 Jun 2013 01:45:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiecY-0002z7-Ej for qemu-devel@nongnu.org; Sat, 01 Jun 2013 01:44:58 -0400 Received: from ozlabs.org ([2402:b800:7003:1:1::1]:41096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiecY-0002xh-2r for qemu-devel@nongnu.org; Sat, 01 Jun 2013 01:44:54 -0400 Date: Sat, 1 Jun 2013 15:22:42 +1000 From: David Gibson Message-ID: <20130601052242.GA12059@boomeroo.fritz.box> References: <9b6a3a52e3f46cfbc1ded9ab56385ec045e46705.1369628289.git.peter.crosthwaite@xilinx.com> <20130529081853.GC5489@boomeroo.fritz.box> <20130529093157.GF5489@boomeroo.fritz.box> <20130531033245.GB5408@boomeroo.fritz.box> <51A85E93.5010507@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: <51A85E93.5010507@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Peter Crosthwaite , qemu-devel@nongnu.org, edgar.iglesias@gmail.com --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 31, 2013 at 10:25:55AM +0200, Paolo Bonzini wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > Il 31/05/2013 05:32, David Gibson ha scritto: > >>> Then again, although we certainly want to keep changes which=20 > >>> require updates to libfdt_env.h rare, I'm not going to rule > >>> out extensions to libfdt which add new (minor) external=20 > >>> dependencies, and therefore changes to libfdt_env.h. > >>>=20 > >>> That said, I did put my correction a bit too strongly. While=20 > >>> libfdt_env.h is notionally always provided by the surrounding=20 > >>> environment, if the packaged one works for your environment,=20 > >>> it's probably a good idea to use it. > >>=20 > >> I think we should be able to consider QEMU as normal enough to=20 > >> use prepacked DTC and just fix the commit message? > >=20 > > I concur. >=20 > Please don't. Fedora is not going to use the bundled dtc because of a > policy against bundling, and Fedora's dtc package doesn't include > libfdt_env.h. Yeah, that makes Fedora's dtc (well, libfdt) package broken. > If David says that the changes are rare enough, let's just fix the > bundled libfdt_env.h. That's definitely not right. If you're using an externally packagd build of libfdt, you must use that external package's libfdt_env.h as well (which in this case is the default version). --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGphSIACgkQaILKxv3ab8ZGRACfb0bz3Ad2R/X1tjt2vF+J7Mid SNsAnj1SZal5sMfO6OhTv3yht2WjvRAf =kSSJ -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--