Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

On Fri, May 31, 2013 at 10:44:33AM +0100, Peter Maydell wrote:
> On 31 May 2013 09:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Please don't.  Fedora is not going to use the bundled dtc because of a
> > policy against bundling, and Fedora's dtc package doesn't include
> > libfdt_env.h.
> 
> It sounds like Fedora's dtc package is broken then -- are you
> going to fix it?
> 
> > If David says that the changes are rare enough, let's just fix the
> > bundled libfdt_env.h.
> 
> ...I don't have an objection to this if we can make it
> work for all versions of libfdt, and if it's a way of
> using libfdt that upstream expects and is happy to support.
> 
> Mostly I'd just like it to be clear how upstream expects us
> to use libfdt and how upstream expects distributions to
> package libfdt, and then make sure we're in line with that.
> It seems like a lot of the problem is that people (us and
> distros) have been guessing in the absence of documentation :-(

Yeah.  Sorry.  Patches welcome..?

The key point of confusion here is that it is the *builder* of libfdt
that's expected to provide libfdt_env.h, not the user.  So if you're
pulling in a prebuilt libfdt from elsewhere, you should be pulling in
libfdt_env.h from the same elsewhere.

So, a distro packaging libfdt must provide the libfdt_env.h it built
with - which in this case I'd expect to be the standard/default
version from the libfdt tree.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]