From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uiecc-0005Fx-OP for qemu-devel@nongnu.org; Sat, 01 Jun 2013 01:45:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiecY-0002z1-EE for qemu-devel@nongnu.org; Sat, 01 Jun 2013 01:44:58 -0400 Received: from ozlabs.org ([203.10.76.45]:48014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiecY-0002xf-2v for qemu-devel@nongnu.org; Sat, 01 Jun 2013 01:44:54 -0400 Date: Sat, 1 Jun 2013 15:38:33 +1000 From: David Gibson Message-ID: <20130601053833.GC12059@boomeroo.fritz.box> References: <9b6a3a52e3f46cfbc1ded9ab56385ec045e46705.1369628289.git.peter.crosthwaite@xilinx.com> <20130529081853.GC5489@boomeroo.fritz.box> <20130529093157.GF5489@boomeroo.fritz.box> <20130531033245.GB5408@boomeroo.fritz.box> <51A85E93.5010507@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ghzN8eJ9Qlbqn3iT" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Peter Crosthwaite , qemu-devel@nongnu.org, edgar.iglesias@gmail.com --ghzN8eJ9Qlbqn3iT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 31, 2013 at 10:44:33AM +0100, Peter Maydell wrote: > On 31 May 2013 09:25, Paolo Bonzini wrote: > > Please don't. Fedora is not going to use the bundled dtc because of a > > policy against bundling, and Fedora's dtc package doesn't include > > libfdt_env.h. >=20 > It sounds like Fedora's dtc package is broken then -- are you > going to fix it? >=20 > > If David says that the changes are rare enough, let's just fix the > > bundled libfdt_env.h. >=20 > ...I don't have an objection to this if we can make it > work for all versions of libfdt, and if it's a way of > using libfdt that upstream expects and is happy to support. >=20 > Mostly I'd just like it to be clear how upstream expects us > to use libfdt and how upstream expects distributions to > package libfdt, and then make sure we're in line with that. > It seems like a lot of the problem is that people (us and > distros) have been guessing in the absence of documentation :-( Yeah. Sorry. Patches welcome..? The key point of confusion here is that it is the *builder* of libfdt that's expected to provide libfdt_env.h, not the user. So if you're pulling in a prebuilt libfdt from elsewhere, you should be pulling in libfdt_env.h from the same elsewhere. So, a distro packaging libfdt must provide the libfdt_env.h it built with - which in this case I'd expect to be the standard/default version from the libfdt tree. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ghzN8eJ9Qlbqn3iT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGpiNkACgkQaILKxv3ab8YYOACgi32+6RyteDUNIgPFaLCOkVV2 tr0AnjzE3e/YcnsmSVcB3+YD1aoBtNON =lsuC -----END PGP SIGNATURE----- --ghzN8eJ9Qlbqn3iT--