qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-stable@nongnu.org, fred.konrad@greensocs.com,
	qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend
Date: Mon, 3 Jun 2013 12:32:43 +0530	[thread overview]
Message-ID: <20130603070243.GA21217@amit.redhat.com> (raw)
In-Reply-To: <bf4505014a0a941dbd3c62068f3cf2c496b69e6a.1370023944.git.crobinso@redhat.com>

On (Fri) 31 May 2013 [14:12:48], Cole Robinson wrote:
> 'default_backend' isn't always set, but 'rng' is, so use that.
> 
> $ ./x86_64-softmmu/qemu-system-x86_64 -object rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0
> Segmentation fault (core dumped)
> 
> Regressed with virtio refactoring in 59ccd20a9ac719cff82180429458728f03ec612f
> 
> CC: qemu-stable@nongnu.org
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> 
> Notes:
>     v2: Fix other instances in s390x code, pointed out by Frederic

Acked-by: Amit Shah <amit.shah@redhat.com>

		Amit

  reply	other threads:[~2013-06-03  7:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31 18:12 [Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend Cole Robinson
2013-06-03  7:02 ` Amit Shah [this message]
2013-06-03 12:12 ` Michael S. Tsirkin
2013-06-12 20:33 ` mdroth
2013-06-21 15:34 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603070243.GA21217@amit.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=fred.konrad@greensocs.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).