From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjOn9-0001cO-5K for qemu-devel@nongnu.org; Mon, 03 Jun 2013 03:03:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjOn4-0001uW-AR for qemu-devel@nongnu.org; Mon, 03 Jun 2013 03:02:55 -0400 Date: Mon, 3 Jun 2013 12:32:43 +0530 From: Amit Shah Message-ID: <20130603070243.GA21217@amit.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: qemu-stable@nongnu.org, fred.konrad@greensocs.com, qemu-devel@nongnu.org, mst@redhat.com On (Fri) 31 May 2013 [14:12:48], Cole Robinson wrote: > 'default_backend' isn't always set, but 'rng' is, so use that. > > $ ./x86_64-softmmu/qemu-system-x86_64 -object rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0 > Segmentation fault (core dumped) > > Regressed with virtio refactoring in 59ccd20a9ac719cff82180429458728f03ec612f > > CC: qemu-stable@nongnu.org > Signed-off-by: Cole Robinson > --- > > Notes: > v2: Fix other instances in s390x code, pointed out by Frederic Acked-by: Amit Shah Amit