From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjPfD-0007ta-Au for qemu-devel@nongnu.org; Mon, 03 Jun 2013 03:58:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjPf6-0004UO-N8 for qemu-devel@nongnu.org; Mon, 03 Jun 2013 03:58:47 -0400 Date: Mon, 3 Jun 2013 09:58:36 +0200 From: Stefan Hajnoczi Message-ID: <20130603075836.GC9435@stefanha-thinkpad.redhat.com> References: <1370001627-11830-1-git-send-email-pbonzini@redhat.com> <51A89B9D.9010404@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51A89B9D.9010404@redhat.com> Subject: Re: [Qemu-devel] [PATCH] do not check pointers after dereferencing them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org, qemu-stable@nongnu.org On Fri, May 31, 2013 at 06:46:21AM -0600, Eric Blake wrote: > On 05/31/2013 06:00 AM, Paolo Bonzini wrote: > > Two instances, both spotted by Coverity. In one, two blocks were > > swapped. In the other, the check is not needed anymore. > > > > Cc: qemu-stable@nongnu.org > > Cc: qemu-trivial@nongnu.org > > Signed-off-by: Paolo Bonzini > > --- > > monitor.c | 2 +- > > savevm.c | 10 +++++----- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > This version of the savevm.c fix is nicer than Stefan's attempt: > https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg04506.html > > Reviewed-by: Eric Blake I'll drop mine. I didn't dare to swap the blocks just in case something dependend on doing the popen() and bailing out afterwards, but it's hard to imagine that. Stefan