From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UjQxQ-00045q-Vp
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 05:21:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UjQxL-0007HE-04
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 05:21:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34488)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UjQxK-0007H9-P4
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 05:21:34 -0400
Date: Mon, 3 Jun 2013 11:21:30 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130603092130.GD16498@stefanha-thinkpad.redhat.com>
References: <1369917299-5725-1-git-send-email-stefanha@redhat.com>
	<1369917299-5725-11-git-send-email-stefanha@redhat.com>
	<51A74FFD.1020207@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51A74FFD.1020207@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com, imain@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, dietmar@proxmox.com

On Thu, May 30, 2013 at 07:11:25AM -0600, Eric Blake wrote:
> On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote:
> > The Abort action can be used to test QMP 'transaction' failure.  Add it
> > as the last action to exercise the .abort() and .cleanup() code paths
> > for all previous actions.
> 
> Another thread questioned whether we should name this action
> __org.qemu-debug-abort, if only to be clear that it is not a normal
> interface.

kwolf: Do you want Abort to be namespaced as a debug-only action?

I think it's perfectly supportable so there's no need to hide it.
Granted it's rare that anyone would want to use this action.

Stefan