Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

[Luiz Capitulino <lcapitulino@redhat.com>]

On Mon, 3 Jun 2013 15:05:03 -0500
mdroth <mdroth@linux.vnet.ibm.com> wrote:

> On Mon, Jun 03, 2013 at 03:54:48PM -0400, Luiz Capitulino wrote:
> > On Mon, 03 Jun 2013 21:13:30 +0200
> > Paolo Bonzini <pbonzini@redhat.com> wrote:
> > 
> > > Il 03/06/2013 19:17, Luiz Capitulino ha scritto:
> > > > This entry doesn't reflect reality for a few years now. This commit
> > > > splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
> > > > as a maintainer.
> > > > 
> > > > This is what we have been for the last few years. Also, it's going
> > > > to help me to offload some of this work to someone else in the near
> > > > future.
> > > > 
> > > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > > > ---
> > > >  MAINTAINERS | 17 +++++++++++++++--
> > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 432185a..45f2e68 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -685,11 +685,12 @@ M: Anthony Liguori <aliguori@us.ibm.com>
> > > >  S: Supported
> > > >  F: vl.c
> > > >  
> > > > -Monitor (QMP/HMP)
> > > > +Human Monitor (HMP)
> > > >  M: Luiz Capitulino <lcapitulino@redhat.com>
> > > > -M: Markus Armbruster <armbru@redhat.com>
> > > >  S: Supported
> > > >  F: monitor.c
> > > > +F: hmp.c
> > > > +F: hmp-commands.hx
> > > >  
> > > >  Network device layer
> > > >  M: Anthony Liguori <aliguori@us.ibm.com>
> > > > @@ -706,6 +707,11 @@ F: nbd.*
> > > >  F: qemu-nbd.c
> > > >  T: git git://github.com/bonzini/qemu.git nbd-next
> > > >  
> > > > +QAPI
> > > > +M: Luiz Capitulino <lcapitulino@redhat.com>
> > > 
> > > Mike Roth too, perhaps?
> > 
> > I'd like to, but last time I asked he sort of refused :)
> > 
> > Michael, can I add you?
> > 
> 
> Haha, well, I think the discussion back then was whether I should send
> QAPI pulls, and I was of the mindset that we should keep sending those
> through the QMP tree since most QAPI changes were in support of QMP.
> 
> According to the MAINTAINERS documentation though, M: is meant to be
> "a set of names that developers can consult when they have a question
> about a particular subset and also to provide a set of names to be
> CC'd when submitting a patch to obtain appropriate review.", so if
> that's the case I'd be happy to add my name and help in that regard.

Oh, that's cool. I'll add your name for v2 then.