Re: [Qemu-devel] [PATCH] virtio-net: fix wrong size of vlan filter table

[Amos Kong <akong@redhat.com>]

On Wed, Jun 05, 2013 at 02:13:48PM +0800, Amos Kong wrote:
> The MAX_VLAN is 4096, currently the vlan filter table has 512
> (4096 >> 3) entries, it's wrong.
> 
> One entry in vlan filter table can indicate 32(1 << 5) vlans,
> so the table should have 128 (4096 >> 5) entries.
> 
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---

This patch breaks the migration.

> btw, it would be simple to use an uint32 number to indicate
> all vlans (same as igbvf). I found e1000 uses the same table.
> Nothing needs to change here, it would cause migration issue.

The comment is wrong, igbvf also uses an array.

Will post a v2 with migration fix.

> ---
>  hw/net/virtio-net.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

-- 
			Amos.