From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uk9WQ-0005Mt-6D for qemu-devel@nongnu.org; Wed, 05 Jun 2013 04:56:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uk9WL-0001Vg-Ly for qemu-devel@nongnu.org; Wed, 05 Jun 2013 04:56:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uk9WL-0001VR-Ep for qemu-devel@nongnu.org; Wed, 05 Jun 2013 04:56:41 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r558udYS017433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Jun 2013 04:56:39 -0400 Date: Wed, 5 Jun 2013 16:56:35 +0800 From: Amos Kong Message-ID: <20130605085635.GA32295@t430s.nay.redhat.com> References: <1370412828-15960-1-git-send-email-akong@redhat.com> <20130605072130.GB4705@t430s.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130605072130.GB4705@t430s.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH] virtio-net: fix wrong size of vlan filter table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, mst@redhat.com On Wed, Jun 05, 2013 at 03:21:30PM +0800, Amos Kong wrote: > On Wed, Jun 05, 2013 at 02:13:48PM +0800, Amos Kong wrote: > > The MAX_VLAN is 4096, currently the vlan filter table has 512 > > (4096 >> 3) entries, it's wrong. > > > > One entry in vlan filter table can indicate 32(1 << 5) vlans, > > so the table should have 128 (4096 >> 5) entries. The patch is wrong, one entry takes 4 bytes. Sorry for the noise. -- Amos.