From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1UkAYh-0000t5-1H
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 06:03:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1UkAYZ-0007nm-B1
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 06:03:10 -0400
Date: Wed, 5 Jun 2013 19:55:23 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20130605095522.GD19511@voom.bne.redhat.com>
References: <1370348465-31652-1-git-send-email-aik@ozlabs.ru>
	<1370348465-31652-5-git-send-email-aik@ozlabs.ru>
	<51AEAEDA.2000304@ozlabs.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="EgVrEAR5UttbsTXg"
Content-Disposition: inline
In-Reply-To: <51AEAEDA.2000304@ozlabs.ru>
Subject: Re: [Qemu-devel] [PATCH 04/13] pseries: savevm support for XICS
 interrupt controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Paul Mackerras <paulus@samba.org>, Alexander Graf <agraf@suse.de>


--EgVrEAR5UttbsTXg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 05, 2013 at 01:22:02PM +1000, Alexey Kardashevskiy wrote:
> On 06/04/2013 10:20 PM, Alexey Kardashevskiy wrote:
[snip]
> > +static int ics_post_load(void *opaque, int version_id)
> > +{
> > +    int i;
> > +    struct ics_state *ics =3D opaque;
> > +
> > +    for (i =3D 0; i < ics->nr_irqs; i++) {
>=20
> Obviously here is a bug...
>=20
> -    for (i =3D 0; i < ics->nr_irqs; i++) {
> +    for (i =3D 0; i < ics->icp->nr_servers; i++) {

Ah.. yes.  Although it would be a little nicer to avoid the duplicate
calls to ics_resend() that will cause.  Still the simple version
should be correct for now.  Please resend with this fixed.

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--EgVrEAR5UttbsTXg
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)

iEYEARECAAYFAlGvCwoACgkQaILKxv3ab8YtKwCeNk4pcptMmwLE5Y+IphdGYJLp
+VIAn1+tMX2F/kr4XRQCFbt1jyE5rPfW
=dI8h
-----END PGP SIGNATURE-----

--EgVrEAR5UttbsTXg--