From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33220)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkBOn-00070w-Pi
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 06:57:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkBOj-0008P8-3S
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 06:57:01 -0400
Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:64514)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkBOi-0008P3-TL
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 06:56:57 -0400
Received: by mail-we0-f169.google.com with SMTP id n57so1187573wev.0
	for <qemu-devel@nongnu.org>; Wed, 05 Jun 2013 03:56:56 -0700 (PDT)
Date: Wed, 5 Jun 2013 12:56:52 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130605105652.GA30326@stefanha-thinkpad.muc.redhat.com>
References: <1369455886-30677-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1369455886-30677-4-git-send-email-xiawenc@linux.vnet.ibm.com>
	<51A0E26A.7020703@redhat.com> <51A2B6DB.5030206@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <51A2B6DB.5030206@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V13 3/6] qmp: add recursive member in
	ImageInfo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com

On Mon, May 27, 2013 at 09:28:59AM +0800, Wenchao Xia wrote:
> 于 2013-5-26 0:10, Eric Blake 写道:
> >On 05/24/2013 10:24 PM, Wenchao Xia wrote:
> >>  void bdrv_query_image_info(BlockDriverState *bs,
> >>                             ImageInfo **p_info,
> >>                             Error **errp)
> >>diff --git a/qapi-schema.json b/qapi-schema.json
> >>index ef1f657..a02999d 100644
> >>--- a/qapi-schema.json
> >>+++ b/qapi-schema.json
> >>@@ -236,6 +236,8 @@
> >>  #
> >>  # @snapshots: #optional list of VM snapshots
> >>  #
> >>+# @backing-image: #optional info of the backing image (since 1.6)
> >>+#
> >>  # Since: 1.3
> >>  #
> >>  ##
> >>@@ -245,7 +247,8 @@
> >>             '*actual-size': 'int', 'virtual-size': 'int',
> >>             '*cluster-size': 'int', '*encrypted': 'bool',
> >>             '*backing-filename': 'str', '*full-backing-filename': 'str',
> >>-           '*backing-filename-format': 'str', '*snapshots': ['SnapshotInfo'] } }
> >>+           '*backing-filename-format': 'str', '*snapshots': ['SnapshotInfo'],
> >>+           '*backing-image': 'ImageInfo' } }
> >
> >The API change looks fine, except there is no code change to actually
> >populate the new field.  This hunk should probably be squashed with the
> >patch that implements the field.  Also, are you missing any changes to
> >qmp-commands.hx?
> >
>   nop, in next patch qmp-commands.hx parts is added. Just to make
> review easier, after that I am fine to squash them.

The qapi change should be together with the code that implements it.  I
need to see the code in order to review the documentation change.

Stefan