From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkBbh-0006ff-KL for qemu-devel@nongnu.org; Wed, 05 Jun 2013 07:10:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkBbe-0004i8-Px for qemu-devel@nongnu.org; Wed, 05 Jun 2013 07:10:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkBbe-0004i2-IH for qemu-devel@nongnu.org; Wed, 05 Jun 2013 07:10:18 -0400 Date: Wed, 5 Jun 2013 14:10:44 +0300 From: "Michael S. Tsirkin" Message-ID: <20130605111044.GL31830@redhat.com> References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> <51AF09FC.50308@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <51AF09FC.50308@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas F=E4rber wrote: > Am 04.06.2013 20:51, schrieb Paolo Bonzini: > > This series changes all PCI devices (the sole to support hotplug > > _and_ use MemoryRegions) to do memory_region_del_subregion at > > unrealize time, and memory_region_destroy at instance_finalize > > time. >=20 > The general idea looks good. >=20 > Could you please follow-up with a patch that switches from exit to > unrealize? What do you guys think about changing the name to something else e.g. "free" or "destroy"? unrealize is not a word in english: http://dictionary.cambridge.org/spellcheck/american-english/?q=3Dunrealiz= e I can do it easily if people agree. > use BUS(), PCI_DEVICE() etc. to hide this. >=20 > Andreas >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg