From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkCU6-0005vU-CD for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:06:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkCU3-0007Y8-0t for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:06:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkCU2-0007Y4-O5 for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:06:30 -0400 Date: Wed, 5 Jun 2013 15:06:56 +0300 From: "Michael S. Tsirkin" Message-ID: <20130605120656.GC2643@redhat.com> References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> <51AF09FC.50308@suse.de> <20130605111044.GL31830@redhat.com> <51AF21C1.3060503@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <51AF21C1.3060503@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori On Wed, Jun 05, 2013 at 01:32:17PM +0200, Andreas F=E4rber wrote: > Am 05.06.2013 13:10, schrieb Michael S. Tsirkin: > > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas F=E4rber wrote: > >> Am 04.06.2013 20:51, schrieb Paolo Bonzini: > >>> This series changes all PCI devices (the sole to support hotplug > >>> _and_ use MemoryRegions) to do memory_region_del_subregion at > >>> unrealize time, and memory_region_destroy at instance_finalize > >>> time. > >> > >> The general idea looks good. > >> > >> Could you please follow-up with a patch that switches from exit to > >> unrealize? > >=20 > > What do you guys think about changing the name to something > > else e.g. "free" or "destroy"? >=20 > I'm not generally opposed to renaming things, but current unrealize is = a > pair with realize, and destroy or free doesn't really fit it's purpose = - > that's instance_finalize. Let's CC Anthony. >=20 > Andreas So @instance_init -> instance_alloc instance_finalize -> @instance_free? > >=20 > > unrealize is not a word in english: > > http://dictionary.cambridge.org/spellcheck/american-english/?q=3Dunre= alize > >=20 > > I can do it easily if people agree. > >=20 > >> use BUS(), PCI_DEVICE() etc. to hide this. > >> > >> Andreas > >> > >> --=20 > >> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > >> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FC= rnberg >=20 >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg