From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkCtt-0002vD-Bt
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:33:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkCtl-0000W7-Gr
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:33:13 -0400
Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:32977)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkCtl-0000V3-AO
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:33:05 -0400
Received: by mail-we0-f169.google.com with SMTP id n57so1253206wev.14
	for <qemu-devel@nongnu.org>; Wed, 05 Jun 2013 05:33:04 -0700 (PDT)
Date: Wed, 5 Jun 2013 14:33:00 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130605123300.GB31478@stefanha-thinkpad.muc.redhat.com>
References: <1369754856-30036-1-git-send-email-kwolf@redhat.com>
	<1369754856-30036-8-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1369754856-30036-8-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com

On Tue, May 28, 2013 at 05:27:27PM +0200, Kevin Wolf wrote:
> diff --git a/cmd.h b/cmd.h
> index ccf6336..d676408 100644
> --- a/cmd.h
> +++ b/cmd.h
> @@ -59,7 +59,6 @@ int command(const cmdinfo_t *ci, int argc, char **argv);
>  
>  /* from input.h */
>  char **breakline(char *input, int *count);
> -void doneline(char *input, char **vec);
>  char *fetchline(void);
>  
>  void cvtstr(double value, char *str, size_t sz);
> @@ -77,4 +76,6 @@ void timestr(struct timeval *tv, char *str, size_t sz, int flags);
>  
>  extern char *progname;
>  
> +bool qemuio_command(const char *cmd);

If we keep cmd.h generic then qemuio_command() should go into another
header file.