From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34588)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkCxp-0004zS-4N
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:37:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkCxk-0001mh-I7
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:37:17 -0400
Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:37463)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UkCxk-0001mb-4i
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:37:12 -0400
Received: by mail-we0-f170.google.com with SMTP id w57so1264712wes.29
	for <qemu-devel@nongnu.org>; Wed, 05 Jun 2013 05:37:11 -0700 (PDT)
Date: Wed, 5 Jun 2013 14:37:07 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130605123707.GC31478@stefanha-thinkpad.muc.redhat.com>
References: <1369754856-30036-1-git-send-email-kwolf@redhat.com>
	<1369754856-30036-9-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1369754856-30036-9-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com

On Tue, May 28, 2013 at 05:27:28PM +0200, Kevin Wolf wrote:
> No reason to treat it different from other commands. Move it to
> qemu-io-cmds.c, adapt the coding style and register it like any other
> command.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  cmd.c          | 79 ----------------------------------------------------------
>  cmd.h          |  1 -
>  qemu-io-cmds.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 66 insertions(+), 81 deletions(-)
> 
> diff --git a/cmd.c b/cmd.c
> index 7ae978f..2941ad3 100644
> --- a/cmd.c
> +++ b/cmd.c

'help' is a generic command, it's not specific to qemu-io.  IMO cmd.c is
the right place for it since other command-line tools might also need
'help'.