From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkD2j-000873-S7 for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:42:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkD2f-0003b9-8S for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:42:21 -0400 Received: from mail-qa0-x22e.google.com ([2607:f8b0:400d:c00::22e]:33372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkD2f-0003b1-3r for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:42:17 -0400 Received: by mail-qa0-f46.google.com with SMTP id ih17so394571qab.19 for ; Wed, 05 Jun 2013 05:42:16 -0700 (PDT) Date: Wed, 5 Jun 2013 14:42:07 +0200 From: Stefan Hajnoczi Message-ID: <20130605124207.GD31478@stefanha-thinkpad.muc.redhat.com> References: <1369754856-30036-1-git-send-email-kwolf@redhat.com> <1369754856-30036-12-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369754856-30036-12-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH 11/16] qemu-io: Move functions for registering and running commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com On Tue, May 28, 2013 at 05:27:31PM +0200, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > cmd.c | 113 --------------------------------- > cmd.h | 11 +--- > qemu-io-cmds.c | 192 ++++++++++++++++++++++++++++++++++++++++++--------------- > qemu-io.c | 10 +-- > 4 files changed, 148 insertions(+), 178 deletions(-) I haven't figured this out yet. These patches move a bunch of generic code and make it qemu-io-specific. That seems the wrong direction to go.