Re: [Qemu-devel] [PATCH v5] NVMe: Initial commit for new storage interface

[Stefan Hajnoczi <stefanha@gmail.com>]

On Tue, Jun 04, 2013 at 09:17:10AM -0600, Keith Busch wrote:
> Initial commit for emulated Non-Volatile-Memory Express (NVMe) pci
> storage device.
> 
> NVMe is an open, industry driven storage specification defining
> an optimized register and command set designed to deliver the full
> capabilities of non-volatile memory on PCIe SSDs. Further information
> may be found on the organizations website at:
> 
> http://www.nvmexpress.org/
> 
> This commit implements the minimum from the specification to work with
> existing drivers.
> 
> Cc: Keith Busch <keith.busch@gmail.com>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> ---
> v4 -> v5: 
>  Call bdrv_flush on controller shutdown.
>  Mark device as 'unmigratable'.
>  More detailed commit message.
>  Block device accounting.
>  Fixed maintainer file for updated hw/ layout.
> 
>  MAINTAINERS              |    5 +
>  default-configs/pci.mak  |    1 +
>  hw/block/Makefile.objs   |    1 +
>  hw/block/nvme.c          |  885 ++++++++++++++++++++++++++++++++++++++++++++++
>  hw/block/nvme.h          |  711 +++++++++++++++++++++++++++++++++++++
>  include/hw/pci/pci_ids.h |    1 +
>  6 files changed, 1604 insertions(+), 0 deletions(-)
>  create mode 100644 hw/block/nvme.c
>  create mode 100644 hw/block/nvme.h

Happy from a block layer perspective.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>