From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38832)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <davej@redhat.com>) id 1UkgVp-0002KD-6r
	for qemu-devel@nongnu.org; Thu, 06 Jun 2013 16:10:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <davej@redhat.com>) id 1UkgVj-0001m4-5B
	for qemu-devel@nongnu.org; Thu, 06 Jun 2013 16:10:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60134)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <davej@redhat.com>) id 1UkgVi-0001l1-To
	for qemu-devel@nongnu.org; Thu, 06 Jun 2013 16:10:15 -0400
Date: Thu, 6 Jun 2013 16:09:33 -0400
From: Dave Jones <davej@redhat.com>
Message-ID: <20130606200932.GB3837@redhat.com>
References: <20130606095456.GA7865@redhat.com>
	<51B0EA30.3020804@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51B0EA30.3020804@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline
 with data
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
Cc: Cong Wang <amwang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, netdev@vger.kernel.org, Jason Wang <jasowang@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Amos Kong <akong@redhat.com>, "David S. Miller" <davem@davemloft.net>

On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
 
 > >  	pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
 > > +	if (vi->mergeable_rx_bufs)
 > > +		hdr_len = sizeof hdr->mhdr;
 > > +	else
 > > +		hdr_len = sizeof hdr->hdr;
 > 
 > All conditionals need braces.
 
Documentation/CodingStyle disagrees:

 "Do not unnecessarily use braces where a single statement will do."
 
	Dave