From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukm0L-0005LU-HR for qemu-devel@nongnu.org; Thu, 06 Jun 2013 22:02:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ukm0G-0002jr-QB for qemu-devel@nongnu.org; Thu, 06 Jun 2013 22:02:13 -0400 Received: from ozlabs.org ([203.10.76.45]:40536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukm0G-0002jk-E8 for qemu-devel@nongnu.org; Thu, 06 Jun 2013 22:02:08 -0400 Date: Fri, 7 Jun 2013 10:45:36 +1000 From: David Gibson Message-ID: <20130607004536.GD24421@voom.bne.redhat.com> References: <1370508534-12335-1-git-send-email-david@gibson.dropbear.id.au> <20130606100149.GB8047@redhat.com> <87y5annuud.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="M38YqGLZlgb6RLPS" Content-Disposition: inline In-Reply-To: <87y5annuud.fsf@codemonkey.ws> Subject: Re: [Qemu-devel] [0/10] Clean up PCI code to allow for multiple root buses (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, "Michael S. Tsirkin" --M38YqGLZlgb6RLPS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 06, 2013 at 10:04:58AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: >=20 > > On Thu, Jun 06, 2013 at 06:48:44PM +1000, David Gibson wrote: > >> The current PCI subsystem has kind of half-hearted support for > >> multiple independent root buses - aka PCI domains - in the form of the > >> PCIHostBus structure and its domain field. However, it doesn't quite > >> work because pci_host_bus_register() is always called with a domain of > >> 0. > >>=20 > >> Worse, though, the whole concept of numbered domains isn't general > >> enough. Many platforms can have independent root buses (usually on > >> wholly independent host bridges), but only x86 gives them a > >> hardware-significant domain number, essentially as a hack to allow all > >> the separate config spaces to be accessed via the same IO ports. > >> Linux guests on other platforms will show domain numbers in lspci, but > >> these are purely guest assigned, so qemu won't know about them. > >>=20 > >> This patch series, therefore, removes the broken-as-is domain concept > >> from qemu, and replaces it with a different way of handling multiple > >> root buses, based on a host bridge class method to provide a > >> identifier for the root bus. This hook is designed in such a way as > >> to allow a single bridge object to support mutiple root buses with > >> future changes, which will allow future implementations of x86 north > >> bridges with multiple domains to be supported correctly, and in way > >> that matches the existing practice for all external interfaces. > >>=20 > >> v2: > >> * Rework concept of "primary" bus in response to Michael Tsirkin's > >> comments. > > > > > > Looks good to me. > > > > Acked-by: Michael S. Tsirkin > > > > I'll wait a bit so others have a chance to comment, then apply > > if everyone is happy. > > > > No need to repost for the lack of -M flag - I wish there was a way > > to specify that in git config. >=20 > [diff] > renames =3D true Oh, thanks. I was looking for a way to configure that, but hadn't found it. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --M38YqGLZlgb6RLPS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) iEYEARECAAYFAlGxLTAACgkQaILKxv3ab8avigCeKc/BUO1oP1BAAZZKad7kd0Ub pPsAoJBKlvBbbs/y/Pv5uMbXv2ZQtSje =zCc8 -----END PGP SIGNATURE----- --M38YqGLZlgb6RLPS--