From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukv7o-0006O8-5t for qemu-devel@nongnu.org; Fri, 07 Jun 2013 07:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ukv7l-0008TA-Kz for qemu-devel@nongnu.org; Fri, 07 Jun 2013 07:46:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukv7l-0008T3-DY for qemu-devel@nongnu.org; Fri, 07 Jun 2013 07:46:29 -0400 Date: Fri, 7 Jun 2013 13:46:25 +0200 From: Stefan Hajnoczi Message-ID: <20130607114625.GA20469@stefanha-thinkpad.redhat.com> References: <1370492881-12410-1-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370492881-12410-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V15 0/5] enhancement for qmp/hmp interfaces of block info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com On Thu, Jun 06, 2013 at 12:27:56PM +0800, Wenchao Xia wrote: > This series lets qmp interface show delaied info, including internal snapshot > /backing chain on all block device at runtime, which helps management stack and > human user, by retrieving exactly the same info of what qemu sees. [...] > V15: > Squash "add recursive member in ImageInfo" patch into 3/6. > Address Stefan's comments: > 5/5: use bool instead of int for variable "verbose". > > Wenchao Xia (5): > 1 block: add snapshot info query function bdrv_query_snapshot_info_list() > 2 block: add image info query function bdrv_query_image_info() > 3 qmp: add ImageInfo in BlockDeviceInfo used by query-block > 4 hmp: show ImageInfo in 'info block' > 5 hmp: add parameters device and -v for info block > > block/qapi.c | 148 ++++++++++++++++++++++++++++++++++++++++++-------- > hmp.c | 21 +++++++ > include/block/qapi.h | 14 +++-- > monitor.c | 7 ++- > qapi-schema.json | 10 +++- > qemu-img.c | 10 +++- > qmp-commands.hx | 69 +++++++++++++++++++++++- > 7 files changed, 242 insertions(+), 37 deletions(-) > > Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan