From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlVt6-00031L-AB for qemu-devel@nongnu.org; Sat, 08 Jun 2013 23:01:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UlVt4-0004wo-0E for qemu-devel@nongnu.org; Sat, 08 Jun 2013 23:01:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlVt3-0004wj-OV for qemu-devel@nongnu.org; Sat, 08 Jun 2013 23:01:45 -0400 Date: Sun, 9 Jun 2013 11:01:41 +0800 From: Fam Zheng Message-ID: <20130609030141.GA21467@localhost.nay.redhat.com> References: <1370674687-13849-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1370674687-13849-11-git-send-email-xiawenc@linux.vnet.ibm.com> <20130608082101.GD9648@localhost.nay.redhat.com> <51B3EADE.6080709@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51B3EADE.6080709@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/11] hmp: add interface hmp_snapshot_internal_blkdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com On Sun, 06/09 10:39, Wenchao Xia wrote: > =E4=BA=8E 2013-6-8 16:21, Fam Zheng =E5=86=99=E9=81=93: > >On Sat, 06/08 14:58, Wenchao Xia wrote: > >>Signed-off-by: Wenchao Xia > >>--- > >> hmp-commands.hx | 24 ++++++++++++++++++++++-- > >> hmp.c | 10 ++++++++++ > >> hmp.h | 1 + > >> 3 files changed, 33 insertions(+), 2 deletions(-) > >> > >>diff --git a/hmp-commands.hx b/hmp-commands.hx > >>index 396691a..65fb94d 100644 > >>--- a/hmp-commands.hx > >>+++ b/hmp-commands.hx > >>@@ -1025,8 +1025,7 @@ ETEXI > >> "of device. If a new image file is specified,= the\n\t\t\t" > >> "new image file will become the new root imag= e.\n\t\t\t" > >> "If format is specified, the snapshot file wi= ll\n\t\t\t" > >>- "be created in that format. Otherwise the\n\t\= t\t" > >>- "snapshot will be internal! (currently unsuppo= rted).\n\t\t\t" > >>+ "be created in that format.\n\t\t\t" > >> "The default format is qcow2. The -n flag re= quests QEMU\n\t\t\t" > >> "to reuse the image found in new-image-file, = instead of\n\t\t\t" > >> "recreating it from scratch.", > >>@@ -1040,6 +1039,27 @@ Snapshot device, using snapshot file as target= if provided > >> ETEXI > >> > >> { > >>+ .name =3D "snapshot_internal_blkdev", > >Hmm, Just a boring naming question: > > > >snapshot_blkdev reads like a verb-object phrase "snapshot the block > >device", but snapshot_internal_blkdev is becoming awkward: "snapshot a > >internal block device"? > Actually in my draft it is named as snapshot_blkdev_internal, but > seems not so good also. I am short of English words, how about > snapshot_internally_blkdev? >=20 I prefer snapshot_blkdev_internal, personally. --=20 Fam