From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ulxhg-00028T-AK for qemu-devel@nongnu.org; Mon, 10 Jun 2013 04:43:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ulxhf-000505-2d for qemu-devel@nongnu.org; Mon, 10 Jun 2013 04:43:52 -0400 Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:59964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ulxhe-0004zz-SH for qemu-devel@nongnu.org; Mon, 10 Jun 2013 04:43:50 -0400 Received: by mail-ee0-f44.google.com with SMTP id c13so2804781eek.17 for ; Mon, 10 Jun 2013 01:43:50 -0700 (PDT) Date: Mon, 10 Jun 2013 10:43:47 +0200 From: Stefan Hajnoczi Message-ID: <20130610084347.GC5308@stefanha-thinkpad.redhat.com> References: <1370634755-18132-1-git-send-email-lcapitulino@redhat.com> <1370634755-18132-4-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370634755-18132-4-git-send-email-lcapitulino@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Fri, Jun 07, 2013 at 03:52:29PM -0400, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > block.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 79ad33d..c78f152 100644 > --- a/block.c > +++ b/block.c > @@ -1291,8 +1291,7 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state, BlockReopenQueue *queue, > if (local_err != NULL) { > error_propagate(errp, local_err); > } else { > - error_set(errp, QERR_OPEN_FILE_FAILED, > - reopen_state->bs->filename); > + error_setg_file_open(errp, errno, reopen_state->bs->filename); Looking closer, my suggestion was wrong too. I think QERR_OPEN_FILE_FAILED is simply the wrong error here. We don't know that the error occurred when trying to open a file. errno does not necessarily contain the error value! Stefan