From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ulxia-0003Lf-UK for qemu-devel@nongnu.org; Mon, 10 Jun 2013 04:44:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UlxiZ-0005Jk-Oj for qemu-devel@nongnu.org; Mon, 10 Jun 2013 04:44:48 -0400 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:34398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlxiZ-0005Ja-Ip for qemu-devel@nongnu.org; Mon, 10 Jun 2013 04:44:47 -0400 Received: by mail-ee0-f41.google.com with SMTP id d17so1458987eek.28 for ; Mon, 10 Jun 2013 01:44:46 -0700 (PDT) Date: Mon, 10 Jun 2013 10:44:44 +0200 From: Stefan Hajnoczi Message-ID: <20130610084444.GD5308@stefanha-thinkpad.redhat.com> References: <1370634755-18132-1-git-send-email-lcapitulino@redhat.com> <1370634755-18132-5-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370634755-18132-5-git-send-email-lcapitulino@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/9] block: mirror_complete(): use error_setg_file_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Fri, Jun 07, 2013 at 03:52:30PM -0400, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/mirror.c b/block/mirror.c > index 8b07dec..89d531d 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -512,7 +512,7 @@ static void mirror_complete(BlockJob *job, Error **errp) > char backing_filename[PATH_MAX]; > bdrv_get_full_backing_filename(s->target, backing_filename, > sizeof(backing_filename)); > - error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename); > + error_setg_file_open(errp, errno, backing_filename); s/errno/-ret/