From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um1Hx-0000t8-Lh for qemu-devel@nongnu.org; Mon, 10 Jun 2013 08:33:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Um1Hw-0005WE-5m for qemu-devel@nongnu.org; Mon, 10 Jun 2013 08:33:33 -0400 Date: Mon, 10 Jun 2013 14:33:28 +0200 From: Kevin Wolf Message-ID: <20130610123328.GF3636@dhcp-200-207.str.redhat.com> References: <11837115.9GZ72nQAUt@al> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11837115.9GZ72nQAUt@al> Subject: Re: [Qemu-devel] [PATCH] gtk: implement -full-screen and -no-frame List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Wu Cc: qemu-trivial@nongnu.org, Anthony Liguori , qemu-devel@nongnu.org Am 09.06.2013 um 12:30 hat Peter Wu geschrieben: > Aiming for GTK as replacement for SDL, features like -full-screen and -no-frame > should also be implemented. > > Bringing the window into full-screen mode is done by faking activating the full > screen menu item with a NULL menu item (which currently is not used by > gd_menu_full_screen). This is done after showing the windows to make the cursor > and menu hidden. > > Signed-off-by: Peter Wu > --- > include/ui/console.h | 2 +- > ui/gtk.c | 10 +++++++++- > vl.c | 2 +- > 3 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/include/ui/console.h b/include/ui/console.h > index 4307b5f..7174ba9 100644 > --- a/include/ui/console.h > +++ b/include/ui/console.h > @@ -339,6 +339,6 @@ int index_from_keycode(int code); > > /* gtk.c */ > void early_gtk_display_init(void); > -void gtk_display_init(DisplayState *ds); > +void gtk_display_init(DisplayState *ds, int full_screen, int no_frame); Should the new arguments be bool? Kevin