From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50563)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Um5fp-0001pV-Og
	for qemu-devel@nongnu.org; Mon, 10 Jun 2013 13:14:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Um5fo-0006XA-Do
	for qemu-devel@nongnu.org; Mon, 10 Jun 2013 13:14:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16580)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Um5fo-0006X3-5H
	for qemu-devel@nongnu.org; Mon, 10 Jun 2013 13:14:28 -0400
Date: Mon, 10 Jun 2013 13:14:26 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130610131426.3cea54f0@redhat.com>
In-Reply-To: <1370805206-26574-12-git-send-email-afaerber@suse.de>
References: <1370805206-26574-1-git-send-email-afaerber@suse.de>
	<1370805206-26574-12-git-send-email-afaerber@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify
	do_inject_mce()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Sun,  9 Jun 2013 21:12:38 +0200
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> Use qemu_get_cpu() to avoid open-coded CPU loop.
>=20
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

> ---
>  monitor.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
>=20
> diff --git a/monitor.c b/monitor.c
> index 6e22d15..19c297d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2013,7 +2013,6 @@ static void do_acl_remove(Monitor *mon, const QDict=
 *qdict)
>  static void do_inject_mce(Monitor *mon, const QDict *qdict)
>  {
>      X86CPU *cpu;
> -    CPUX86State *cenv;
>      CPUState *cs;
>      int cpu_index =3D qdict_get_int(qdict, "cpu_index");
>      int bank =3D qdict_get_int(qdict, "bank");
> @@ -2026,14 +2025,11 @@ static void do_inject_mce(Monitor *mon, const QDi=
ct *qdict)
>      if (qdict_get_try_bool(qdict, "broadcast", 0)) {
>          flags |=3D MCE_INJECT_BROADCAST;
>      }
> -    for (cenv =3D first_cpu; cenv !=3D NULL; cenv =3D cenv->next_cpu) {
> -        cpu =3D x86_env_get_cpu(cenv);
> -        cs =3D CPU(cpu);
> -        if (cs->cpu_index =3D=3D cpu_index) {
> -            cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr,=
 misc,
> -                               flags);
> -            break;
> -        }
> +    cs =3D qemu_get_cpu(cpu_index);
> +    if (cs !=3D NULL) {
> +        cpu =3D X86_CPU(cs);
> +        cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr, mis=
c,
> +                           flags);
>      }
>  }
>  #endif