From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <anthony@codemonkey.ws>,
David Woodhouse <dwmw2@infradead.org>,
seabios@seabios.org, qemu-devel@nongnu.org,
Kevin O'Connor <kevin@koconnor.net>,
Jordan Justen <jljusten@gmail.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support
Date: Tue, 11 Jun 2013 09:55:25 +0300 [thread overview]
Message-ID: <20130611065525.GB31474@redhat.com> (raw)
In-Reply-To: <51B6B68E.9040508@redhat.com>
On Tue, Jun 11, 2013 at 07:33:02AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > * Use of glib's GArray makes it much easier to build
> > up tables in code without need for iasl and code patching
>
> Nice.
>
> > Design:
> > - each bus gets assigned a number 0-255
> > - generated ACPI code writes this number
> > to a new BSEL register, then uses existing
> > UP/DOWN registers to probe slot status;
> > to eject, write number to BSEL register,
> > then slot into existing EJ
> >
> > This is to address the ACPI spec requirement to
> > avoid config cycle access to any bus except PCI roots.
> >
> > Portability:
> > - Non x86 (or any Linux) platforms don't need any of this code.
> > They can keep happily using SHPC the way
> > they always did.
>
> Hmm. Is is possible to write a SHPC driver in AML? I think it would be
> alot better to have one guest/host interface for pci bridge hotplug
> instead of two.
>
> cheers,
> Gerd
No, it's not possible, SHPC is not designed to be used from ACPI.
Two reasons off the top of my head, there are likely others:
1. SHPC uses regular PCI interrupts to signal events. It does not signal
GFE and SCI.
2. SHPC uses config accesses to get information from device.
ACPI does not allow config access anywhere except the root bus from ACPI
(This requirement is designed to give the OS freedom
to reconfigure PCI in an arbitrary way).
--
MST
next prev parent reply other threads:[~2013-06-11 6:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 16:41 [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support Michael S. Tsirkin
2013-06-10 18:58 ` Anthony Liguori
2013-06-10 19:17 ` Peter Maydell
2013-06-10 19:50 ` Anthony Liguori
2013-06-10 19:43 ` Laszlo Ersek
2013-06-10 19:57 ` Anthony Liguori
2013-06-10 20:43 ` Laszlo Ersek
2013-06-10 21:14 ` Laszlo Ersek
2013-06-10 21:45 ` Anthony Liguori
2013-06-10 23:05 ` Kevin O'Connor
2013-06-10 23:34 ` Anthony Liguori
2013-06-10 23:52 ` David Woodhouse
2013-06-11 0:11 ` Anthony Liguori
2013-06-11 14:11 ` David Woodhouse
2013-06-11 0:23 ` Kevin O'Connor
2013-06-11 0:51 ` Anthony Liguori
2013-06-11 1:19 ` Kevin O'Connor
2013-06-11 1:25 ` Anthony Liguori
2013-06-11 1:49 ` Kevin O'Connor
2013-06-11 6:49 ` Michael S. Tsirkin
2013-06-11 0:28 ` Jordan Justen
2013-06-11 1:03 ` Anthony Liguori
2013-06-11 1:32 ` Jordan Justen
2013-06-11 7:35 ` Michael S. Tsirkin
2013-06-13 23:05 ` Paolo Bonzini
2013-06-14 0:59 ` Anthony Liguori
2013-06-14 1:23 ` [Qemu-devel] [SeaBIOS] " Peter Stuge
2013-06-11 14:04 ` David Woodhouse
2013-06-13 23:02 ` [Qemu-devel] " Paolo Bonzini
2013-06-14 0:26 ` Laszlo Ersek
2013-06-16 10:00 ` Laszlo Ersek
2013-06-11 5:22 ` Michael S. Tsirkin
2013-06-11 5:33 ` Gerd Hoffmann
2013-06-11 6:55 ` Michael S. Tsirkin [this message]
2013-06-11 7:42 ` Gerd Hoffmann
2013-06-11 7:53 ` Michael S. Tsirkin
2013-06-11 8:00 ` Gerd Hoffmann
2013-06-11 8:18 ` Michael S. Tsirkin
2013-06-11 8:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130611065525.GB31474@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=dwmw2@infradead.org \
--cc=jljusten@gmail.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).