From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmIUB-0001zX-PN for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:55:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmIU9-0007eS-7r for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:55:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmIU8-0007e9-WB for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:55:17 -0400 Date: Tue, 11 Jun 2013 09:55:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20130611065525.GB31474@redhat.com> References: <1370882347-31129-1-git-send-email-mst@redhat.com> <51B6B68E.9040508@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51B6B68E.9040508@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Peter Maydell , Anthony Liguori , David Woodhouse , seabios@seabios.org, qemu-devel@nongnu.org, Kevin O'Connor , Jordan Justen , Laszlo Ersek On Tue, Jun 11, 2013 at 07:33:02AM +0200, Gerd Hoffmann wrote: > Hi, > > > * Use of glib's GArray makes it much easier to build > > up tables in code without need for iasl and code patching > > Nice. > > > Design: > > - each bus gets assigned a number 0-255 > > - generated ACPI code writes this number > > to a new BSEL register, then uses existing > > UP/DOWN registers to probe slot status; > > to eject, write number to BSEL register, > > then slot into existing EJ > > > > This is to address the ACPI spec requirement to > > avoid config cycle access to any bus except PCI roots. > > > > Portability: > > - Non x86 (or any Linux) platforms don't need any of this code. > > They can keep happily using SHPC the way > > they always did. > > Hmm. Is is possible to write a SHPC driver in AML? I think it would be > alot better to have one guest/host interface for pci bridge hotplug > instead of two. > > cheers, > Gerd No, it's not possible, SHPC is not designed to be used from ACPI. Two reasons off the top of my head, there are likely others: 1. SHPC uses regular PCI interrupts to signal events. It does not signal GFE and SCI. 2. SHPC uses config accesses to get information from device. ACPI does not allow config access anywhere except the root bus from ACPI (This requirement is designed to give the OS freedom to reconfigure PCI in an arbitrary way). -- MST